Growth · Code review
Four review comments that changed how I work
Four times code review told me I got it wrong, and the habit that each one gave me.
Good review is not always pleasant. These four comments were hard to read. Each one gave me a habit that I still use.
- 01
I rewrote a feature that needed only a small fix.
Now I read the existing feature before I change it. I fix in place by default, and I prefer a fix that deletes code.
- 02
My fix did not address the root cause.
Now I read the ticket again, start from the symptom and prove the cause. I write a failing test first, then I fix the bug, not only the error message.
- 03
My new chart looked different, and it defined its numbers again.
Now I keep the approved design, and I define every number once, in one shared place. A ratio is the sum of the numerators over the sum of the denominators. I never average percentages that have different denominators.
- 04
I shipped a performance fix without a benchmark.
Now I measure performance. I do not guess it.
What I learned about myself
- Lead with the answer.
- Proof is part of the work, not an extra.
- Check the source before you state a conclusion.
- Keep each change small, so one reviewer can merge it fast.
- Review AI output before another person reads it.